Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes order argument from order:[FooSortInput] to order:[FooSortInput!] #2625

Merged
merged 8 commits into from Nov 21, 2020
Merged

Changes order argument from order:[FooSortInput] to order:[FooSortInput!] #2625

merged 8 commits into from Nov 21, 2020

Conversation

PascalSenn
Copy link
Member

  • Changes order argument from order:[FooSortInput] to order:[FooSortInput!]
  • Uses convention also for initial argument
  • Allows overriding by extensions
  • Rename DefaultSortEnumType to SortEnumType in SDL

michaelstaib
michaelstaib previously approved these changes Nov 21, 2020
View reviewed changes
@michaelstaib michaelstaib changed the title Sorting cleanup Changes order argument from order:[FooSortInput] to order:[FooSortInput!] Nov 21, 2020
@michaelstaib michaelstaib added 🌶 hot chocolate 🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better. labels Nov 21, 2020
@michaelstaib michaelstaib added this to backlog in Backlog via automation Nov 21, 2020
@michaelstaib michaelstaib added this to the HC-11.0.0 milestone Nov 21, 2020
@michaelstaib michaelstaib moved this from backlog to review in Backlog Nov 21, 2020
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

77.5% 77.5% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit 106a37a into main Nov 21, 2020
@michaelstaib michaelstaib deleted the pse/sorting-hotfixes branch November 21, 2020 15:34
@PascalSenn PascalSenn moved this from review to Done in Backlog Nov 21, 2020
michaelstaib pushed a commit that referenced this pull request Nov 27, 2020
@PascalSenn @michaelstaib
Changes order argument from order:[FooSortInput] to order:[FooSortInp…
de3dae5 
…ut!] (#2625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib left review comments

Assignees

@PascalSenn PascalSenn

Labels
🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better.
Projects
No open projects
Backlog
  
Done
Milestone
HC-11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PascalSenn @michaelstaib