Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Star Wars example #3481

Merged
merged 12 commits into from Apr 11, 2021
Merged

Fix Star Wars example #3481

merged 12 commits into from Apr 11, 2021

Conversation

tobias-tengler
Copy link
Collaborator

Closes #3480

@tobias-tengler tobias-tengler marked this pull request as ready for review April 11, 2021 14:11
@tobias-tengler
Copy link
Collaborator Author

tobias-tengler commented Apr 11, 2021

I think it would be great to also get rid of the 'ExtendObjectTypeAttribute.Name.set' is obsolete warnings, but I couldn't find how I would do this properly. Maybe one of the maintainers can chime in! ;)

I'm also not sure, if the template is being released as part of the CD process, so maybe it needs to be published manually...

michaelstaib
michaelstaib previously approved these changes Apr 11, 2021
@michaelstaib
Copy link
Member

[ExtendObjectType("Foo")] instead of [ExtendObjectType(Name = "Foo")] will remove the obsolete messages.

@tobias-tengler
Copy link
Collaborator Author

tobias-tengler commented Apr 11, 2021

Removed all the obsolete warnings! :)
I also took the liberty to change the obsolete message of the SchemaType on UsePagingAttribute. "Use Type." was misleading, since the setter of Type is private, so it can't be used as a replacement and the constructor should be used instead.

@michaelstaib
Copy link
Member

@tobias-tengler I updated the build and replaced the attribute for friends with the new extension API. Also I am now using the operation constants on the attributes and simplified the startup.

@michaelstaib
Copy link
Member

.AddQueryType()
                        .AddTypeExtension<CharacterQueries>()
                        .AddTypeExtension<ReviewQueries>()
                    .AddMutationType()
                        .AddTypeExtension<ReviewMutations>()
                    .AddSubscriptionType()
                        .AddTypeExtension<ReviewSubscriptions>()

@michaelstaib
Copy link
Member

If you are happy with the PR I can merge it.

@tobias-tengler
Copy link
Collaborator Author

Looks good to me! :)

@michaelstaib michaelstaib merged commit c67ab3e into ChilliCream:main Apr 11, 2021
@tobias-tengler tobias-tengler deleted the fix-starwars-example branch April 11, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Star Wars example
2 participants