Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Extending Filtering documentation example #3523

Merged
merged 1 commit into from Apr 19, 2021
Merged

Fixed Extending Filtering documentation example #3523

merged 1 commit into from Apr 19, 2021

Conversation

tobias-tengler
Copy link
Collaborator

Closes #3442

@tobias-tengler tobias-tengler added the 📚 documentation This issue is about working on our documentation. label Apr 17, 2021
@tobias-tengler tobias-tengler mentioned this pull request Apr 17, 2021
Closed
PascalSenn
PascalSenn requested changes Apr 18, 2021
View reviewed changes
Copy link
Member

@PascalSenn PascalSenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @tobias-tengler
I think this should do

website/src/docs/hotchocolate/api-reference/extending-filtering.md Show resolved Hide resolved
website/src/docs/hotchocolate/api-reference/extending-filtering.md Outdated Show resolved Hide resolved
@tobias-tengler tobias-tengler force-pushed the tte/fix-extending-filtering-docs branch from 211a078 to c87cba8 Compare April 19, 2021 14:49
@tobias-tengler tobias-tengler marked this pull request as ready for review April 19, 2021 14:51
@tobias-tengler tobias-tengler force-pushed the tte/fix-extending-filtering-docs branch from 215e1b1 to 055ca19 Compare April 19, 2021 16:32
@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tobias-tengler
Copy link
Collaborator Author

@PascalSenn this should be ready to go. I'm not sure why your requested changes are still blocking the PR, I already resolved them...

@PascalSenn PascalSenn changed the title Fix Extending Filtering documentation Fixed Extending Filtering documentation example Apr 19, 2021
@PascalSenn PascalSenn merged commit a9be72d into main Apr 19, 2021
@PascalSenn PascalSenn deleted the tte/fix-extending-filtering-docs branch April 19, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalSenn PascalSenn PascalSenn approved these changes

Assignees
No one assigned
Labels
📚 documentation This issue is about working on our documentation. 🌶️ website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Your documentation page has non compiling code
2 participants
@tobias-tengler @PascalSenn