Fixed interface inference. #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobias-tengler 11 or 12 that is the question :) |
|
Kudos, SonarCloud Quality Gate passed! |
|
Sorry I was having Dinner and couldn't take a look :/ About the public API, it's only to be marked shipped once a version has been released, otherwise it should just be added to the unshipped APIs. I guess it's fine, since you wanted to make a cut tonight for 11.3 though. |
tobias-tengler
added a commit
that referenced
this pull request
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes interface inference with the annotation-based approach. With V12 we need to rework this further and allow for type opt-out of inference.