Close open WebSocket sessions when application is shutting down #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/websocksession-applicationshuttingdown
|
Will have a look at this tomorrow. |
PascalSenn
reviewed
Feb 17, 2022
There was a problem hiding this comment.
Thanks for the PR! :) 👏
This looks good to me, @michaelstaib you have the subscriptions currenlty on the brain stack, any objections for this?
src/HotChocolate/AspNetCore/src/AspNetCore/WebSocketSubscriptionMiddleware.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/AspNetCore/src/AspNetCore/Subscriptions/WebSocketSession.cs
Outdated
Show resolved
Hide resolved
…onMiddleware.cs Co-authored-by: PascalSenn <senn.pasc@gmail.com>
…s://github.com/oising/hotchocolate into feature/websocksession-applicationshuttingdown
|
Related #4813 |
12.7.1? update: never mind, I see you've moved it to v13 |
michaelstaib
approved these changes
Mar 14, 2022
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed! |
1 task
michaelstaib
pushed a commit
that referenced
this pull request
Jun 21, 2022
…n is shutting down" (#5166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dotnet core process hosting hotchocolate is signaled to shutdown, any open websocket sessions (i.e. subscriptions) will cause the shutdown process to stall until the default timeout, which is 30 seconds. At this point, the process is forcefully terminated. While the default is 30 seconds, some people (namely me, lol) have longer timeouts due to other things going on in their server. This makes my k8s rolling upgrades take a lot longer than I'd like :)
I noticed that WebSocket sessions are not explicitly closed on application shutdown. This PR adds that functionality.