Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds expression support for filtering #4877

Merged
merged 10 commits into from Apr 16, 2022
Merged

Adds expression support for filtering #4877

merged 10 commits into from Apr 16, 2022

Conversation

PascalSenn
Copy link
Member

@PascalSenn PascalSenn commented Mar 19, 2022 •
edited

Adds expression support for filtering

@PascalSenn PascalSenn added the 🎬 ready Ready to merge label Mar 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.9% 82.9% Coverage
6.3% 6.3% Duplication

@PascalSenn PascalSenn added this to Ready to Merge in Merge Apr 16, 2022
@michaelstaib michaelstaib merged commit ad668d7 into main Apr 16, 2022
@michaelstaib michaelstaib deleted the pse/add-expressions-to-filtering-2 branch April 16, 2022 20:21
@PascalSenn PascalSenn removed this from Ready to Merge in Merge Apr 16, 2022
@Jonatthu
Copy link

Jonatthu commented Jul 4, 2022

Why not to produce instead an array of the enum on the graphql side?

Like:

'''
myQuery(where { type: [Flag1, Flag2] }) {...}
'''

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
🌶️ hot chocolate 🎬 ready Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PascalSenn @Jonatthu @michaelstaib