Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed type trimming. The trimmer now correctly visits directives. #4917

Merged
merged 3 commits into from Apr 14, 2022
Merged

Fixed type trimming. The trimmer now correctly visits directives. #4917

merged 3 commits into from Apr 14, 2022

Conversation

vhatsura
Copy link
Contributor

@vhatsura vhatsura commented Apr 3, 2022 •
edited by michaelstaib

Summary of the changes

  • Visit directive type during schema trim to add types from arguments into the final schema

Closes #4712

@vhatsura vhatsura force-pushed the vhatsura/type-trimmer-issue branch from 1e6e637 to 1494b65 Compare April 5, 2022 19:52
@vhatsura vhatsura marked this pull request as ready for review April 5, 2022 20:04
@vhatsura vhatsura force-pushed the vhatsura/type-trimmer-issue branch from d56385c to 913706a Compare April 9, 2022 08:50
@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib changed the title visit directive from discovered types during trim Fixed type trimming. The trimmer no correctly visits directives. Apr 14, 2022
@michaelstaib michaelstaib merged commit 022636f into main Apr 14, 2022
@michaelstaib michaelstaib deleted the vhatsura/type-trimmer-issue branch April 14, 2022 18:22
@michaelstaib michaelstaib changed the title Fixed type trimming. The trimmer no correctly visits directives. Fixed type trimming. The trimmer now correctly visits directives. Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
🌶️ hot chocolate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using 'RemoveUnreachableTypes' option in HC 12 breaks BCP (and other graphql IDEs)
2 participants
@vhatsura @michaelstaib