New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming behavior of CollectionSegments to Connections #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalSenn
changed the title
Gkf/collection segment naming#4362
Align naming behavior of CollectionSegments to Connections
Apr 7, 2022
/azurepipelines run |
Azure Pipelines successfully started running 3 pipeline(s). |
…ream/hotchocolate into gkf/CollectionSegmentNaming#4362
michaelstaib
reviewed
May 4, 2022
src/HotChocolate/Core/src/Types.OffsetPagination/CollectionSegmentType~1.cs
Show resolved
Hide resolved
michaelstaib
reviewed
May 4, 2022
src/HotChocolate/Core/test/Types.OffsetPagination.Tests/IntegrationTests.cs
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align naming behavior of CollectionSegments to Connections
work in progress
Closes #4362