Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect UseXmlDocumentation with Schema.Create #897

Merged
merged 3 commits into from
Jul 7, 2019
Merged

Respect UseXmlDocumentation with Schema.Create #897

merged 3 commits into from
Jul 7, 2019

Conversation

nigel-sampson
Copy link
Contributor

@nigel-sampson nigel-sampson commented Jul 7, 2019 •
edited

Fixes a bug in SchemaOptions.FromOptions to correctly copy the UseXmlDocumentation setting.

Resolves #895

@michaelstaib michaelstaib added the 🐛 bug Something isn't working label Jul 7, 2019
@michaelstaib michaelstaib added this to the 9.1.0 milestone Jul 7, 2019
@michaelstaib michaelstaib merged commit 6cc1ca5 into ChilliCream:master Jul 7, 2019
@nigel-sampson nigel-sampson deleted the schema-create-xml-docs branch July 7, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees

@nigel-sampson nigel-sampson

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

UseXmlDocumentation is ignored with Schema.Create
2 participants
@nigel-sampson @michaelstaib