Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redis Provider for Subscriptions #902

Merged
merged 23 commits into from
Jul 19, 2019
Merged

Add Redis Provider for Subscriptions #902

merged 23 commits into from
Jul 19, 2019

Conversation

glucaci
Copy link
Contributor

@glucaci glucaci commented Jul 9, 2019

WIP for #296

@michaelstaib michaelstaib self-requested a review July 9, 2019 14:22
@michaelstaib michaelstaib added the 🎉 enhancement New feature or request label Jul 9, 2019
@michaelstaib michaelstaib added this to the 10.0.0 milestone Jul 9, 2019
@michaelstaib
Copy link
Member

@glucaci Is this one ready to be merged?

@glucaci
Copy link
Contributor Author

glucaci commented Jul 10, 2019

Not yet, still to implement something on message serialization

@michaelstaib
Copy link
Member

ah ok, almost forgot about that.

@glucaci
Copy link
Contributor Author

glucaci commented Jul 18, 2019

I think we are good to go, we still have to setup some infrastructure for the tests (are all skipped)

michaelstaib
michaelstaib reviewed Jul 19, 2019
View reviewed changes
Copy link
Member

@michaelstaib michaelstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the tests and setup all the build infrastructure for this one.... it should work now.

@michaelstaib
Copy link
Member

https://hotchocolate.io/docs/next/code-first-subscription#redis-provider

@michaelstaib michaelstaib merged commit 0cf04dd into ChilliCream:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib left review comments

Assignees

@glucaci glucaci

Labels
🎉 enhancement New feature or request
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glucaci @michaelstaib