Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch Query Executor #933

Merged
merged 39 commits into from
Jul 30, 2019
Merged

Batch Query Executor #933

merged 39 commits into from
Jul 30, 2019

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Jul 22, 2019 •
edited

Fixes #695

@michaelstaib michaelstaib self-assigned this Jul 22, 2019
@michaelstaib michaelstaib added the 🎉 enhancement New feature or request label Jul 22, 2019
@michaelstaib michaelstaib added this to the 10.0.0 milestone Jul 22, 2019
@michaelstaib michaelstaib changed the title Introduced Query Batch Executor Batch Query Executor Jul 22, 2019
@michaelstaib
Copy link
Member Author

The batch executor is now in. We should make the executor a lot more efficient. We could cache a lot and avoid rewriting to many times the incoming query.

We also have to add a lot more tests to cover all cases. Especially when exporting objects or lists.

@michaelstaib
Copy link
Member Author

The question remains... should we alow @export on lists and objects? or should it only go on scalars?

@michaelstaib
Copy link
Member Author

The batch executor is now integrated into the post middleware ...

@michaelstaib michaelstaib merged commit 4e4c3a7 into master Jul 30, 2019
@michaelstaib michaelstaib deleted the batching branch July 30, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelstaib michaelstaib

Labels
🎉 enhancement New feature or request
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

Support for Batching
1 participant
@michaelstaib