Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks value manipulation #37

Open
Chillu1 opened this issue Nov 11, 2023 · 0 comments
Open

Checks value manipulation #37

Chillu1 opened this issue Nov 11, 2023 · 0 comments
Labels
enhancement New feature or request modifier logic request New modifier logic for more lacking functionality

Comments

@Chillu1
Copy link
Owner

Chillu1 commented Nov 11, 2023

Why this logic should be in the library, and not user game logic
Checks values are either fed through constructors, or the supplied unit. This becomes an issue when we want more control over the values inside, like changing cooldown timer, cost or chance.

Describe the solution you'd like
Either feeding some kind of state to the checks (either through unit or something separate), or doing manipulation through callbacks/other setup.

Describe alternatives you've considered, and why they don't work
Custom checks are not ideal since we'd need to store data about it directly in the unit, without any refactoring. Which is a bad solution.

Possible issues
Previous checks without mutable state will now most likely not be a thing, unless that mutable state is stored outside the checks and fed instead.

@Chillu1 Chillu1 added enhancement New feature or request modifier logic request New modifier logic for more lacking functionality labels Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modifier logic request New modifier logic for more lacking functionality
Projects
None yet
Development

No branches or pull requests

1 participant