Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklisted videos are shown on the overview page. #1049

Closed
JohnXLivingston opened this issue Sep 11, 2018 · 7 comments
Closed

Blacklisted videos are shown on the overview page. #1049

JohnXLivingston opened this issue Sep 11, 2018 · 7 comments
Labels
Component: Moderation :godmode: Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor

Comments

@JohnXLivingston
Copy link
Contributor

JohnXLivingston commented Sep 11, 2018

Peertube version : beta 12.
I just blacklisted a video on my instance : https://www.yiny.org/videos/watch/0159317d-5bf1-45ed-ae64-d0c9a82f5abf

But on the overview page, it is still listed, even when I'm not logged in as an admin.
https://www.yiny.org/videos/overview
(the video is called «Sepultura - Territory [OFFICIAL VIDEO]»)

@rigelk rigelk added Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor Component: Moderation :godmode: labels Sep 11, 2018
@Chocobozzz
Copy link
Owner

@JohnXLivingston It's because the overview route is cached for 1 hour.

@rigelk rigelk closed this as completed Sep 15, 2018
@rigelk
Copy link
Collaborator

rigelk commented Sep 15, 2018

@Chocobozzz maybe we should invalidate the overview cache upon moderation?

@Chocobozzz
Copy link
Owner

Yes, so I think this we should keep this issue opened :)

@realityfabric
Copy link
Contributor

Is this also why muting an account doesn't remove the account's videos from the Overview page?

@realityfabric
Copy link
Contributor

After 2 hours, videos from an account I muted are still on the Overview page, so it would seem I was wrong about these things being connected.

@Chocobozzz
Copy link
Owner

Overviews page is global, and does not take into account muted accounts. We should definitely change this behaviour.

@Chocobozzz
Copy link
Owner

Fixed in 764a965 & 111fdc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Moderation :godmode: Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor
Projects
None yet
Development

No branches or pull requests

4 participants