Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded videos trigger 429 TOO MANY REQUESTS #4016

Closed
fabiomaschi opened this issue Apr 25, 2021 · 2 comments
Closed

Embedded videos trigger 429 TOO MANY REQUESTS #4016

fabiomaschi opened this issue Apr 25, 2021 · 2 comments

Comments

@fabiomaschi
Copy link

Describe the current behavior
We are embedding several (>15) videos into a single page on an external website, and peertube responds with HTTP 409: TOO MANY REQUESTS for several requests.

Screenshot 2021-04-20 at 13 42 36

Screenshot 2021-04-20 at 13 42 08

Steps to reproduce:

  1. Create a dummy HTML page
  2. Embed any 20 videos from the same instance
  3. Open the page

Describe the expected behavior
A larger number of embedded videos (thumbnails and video player) should be properly loaded without triggering error 429. Maybe we could try to reduce the number of calls (e.g., I see captions being loaded before playing the video)?

Additional information
I've tried removing all limit_rate and similar modules from /etc/nginx/sites-available/peertube, but the behaviour persists. I also tried to add ngx_http_limit_req_module, ngx_http_limit_conn_module and follow this guide, but I couldn't manage to solve the issue (either by increasing the limit, either by just removing any limit protection).

Question: is there any other component that could raise 429 error code other than NGINX?

Thank you

@fabiomaschi fabiomaschi changed the title Embedded videos trigger 420 TOO MANY REQUESTS Embedded videos trigger 429 TOO MANY REQUESTS Apr 25, 2021
@Chocobozzz
Copy link
Owner

Hello,

Rate limit is defined in peertube config: https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L11

(e.g., I see captions being loaded before playing the video)?

It should be fixed in the next release (we'll lazy load captions)

@rasos
Copy link

rasos commented Jan 25, 2024

embedded videos have a post to the api endpoint, so we had to increase the value for api to 500 for a web page with many videos embedded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants