Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable allowing download video by default #4269

Closed
kirill2400 opened this issue Jul 22, 2021 · 13 comments
Closed

Disable allowing download video by default #4269

kirill2400 opened this issue Jul 22, 2021 · 13 comments

Comments

@kirill2400
Copy link

How to set "allow download video" setting when publishing to false in config by default? I did not found this setting in production.yaml. I have many video that must be undownloadable

@SimplyCorbett
Copy link

You can save videos as internal but anyone who logs in will still be able to download them.

You can't disable downloads.

@kirill2400
Copy link
Author

kirill2400 commented Jul 22, 2021

I am saying about this toggle
image
"Allow download video"

@SimplyCorbett
Copy link

Oh. It's in the advanced settings when publishing the video.

I'll shutup and let Chocobozzz answer you.

@frankstrater
Copy link
Contributor

You can't configure the default for downloadEnabled (and commentsEnabled). It's hardcoded to true as default.

@Alterak
Copy link
Contributor

Alterak commented Jul 22, 2021

I also really want this daw to be unchecked by default. I have asked this question for a long time. Or, for example, by default, for all videos, leave only the torrent download, but disable direct file download.

@Chocobozzz Chocobozzz added Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development Type: Feature Request ✨ and removed Type: Question labels Aug 2, 2021
@tio-trom
Copy link

I strongly suggest to have this as default per user basis. I, as admin, would like to be able to set a global default. I think the download button is a fantastic thing and in par with what Peertube stands for: free, open. Opposite of youtube: locked.

@rscmbbng
Copy link

+1 on an admin setting to set the default value of the download button to off and the ability for users to turn it on.

@kirill2400
Copy link
Author

@Alterak @tio-trom @rscmbbng
I tried to make my first plugin that would at least sort of solve this problem
See the link (within 24 hours it will appear in the pertube register):
https://www.npmjs.com/package/peertube-plugin-denydownload
https://github.com/kirill2400/peertube-plugin-download-video-switcher
You can help if you want

@rscmbbng
Copy link

rscmbbng commented Oct 1, 2021

@kirill2400 thank you for that! However, I think such a rudimentary feature should be part of the upstream project.

@kirill2400
Copy link
Author

@kirill2400 thank you for that! However, I think such a rudimentary feature should be part of the upstream project.

Thanks, but I remind you that what I did is blocking the download of the video in the modal window, that is, it will not be possible to download even what is allowed with a checkmark.

@Chocobozzz Chocobozzz removed the Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development label Dec 10, 2021
@Chocobozzz Chocobozzz self-assigned this Dec 10, 2021
@Chocobozzz
Copy link
Owner

Default value of this setting can now be changed by admins: https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L81

@kirill2400
Copy link
Author

Default value of this setting can now be changed by admins: https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L81

Is it working in 4.0.0?

@Chocobozzz
Copy link
Owner

No it will be included in 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants