Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fionnachan / Refinement Bash #1044

Merged
merged 16 commits into from Dec 14, 2021
Merged

fionnachan / Refinement Bash #1044

merged 16 commits into from Dec 14, 2021

Conversation

fionnachan
Copy link
Contributor

@fionnachan fionnachan commented Dec 14, 2021

View deployed site here

Changes

Refactoring

  • remove package-lock.json because there is already yarn.lock and they should not exist together
  • remove jquery and use useRef to control style changes for expansion / collapse of tabs in FAQ and Voting cards
  • add styled-components for styling
  • add typescript to help development & better code maintenance
    • move some .js to .tsx
    • use type and interface
  • move ElecitonCard out of Election List as a separate component
  • move FAQ question item out of FAQ as a separate component
  • remove unused files
  • use AlgoExplorer API for testnet instead of purestake with hardcoded token in the code base

Features

  • connect wallet button on header
  • add Algorand wallet option
  • show user's Choice coin balance
  • show user's committed Choice coin
  • allow user to input Choice coin amount for voting
  • add icons to dark/light mode toggle

Screenshot

Connect Wallet button
image
Algorand Wallet option
image
Input for Choice coin vote amount & header commitment amount
image

For #984

@ChoiceCoin ChoiceCoin merged commit 448e31d into ChoiceCoin:main Dec 14, 2021
@Bhaney44
Copy link
Collaborator

This is seriously amazing!

@Arch222
Copy link
Contributor

Arch222 commented Dec 14, 2021

Hey, the Algorand Mobile Wallet Feature does not seem to be working for me. Is this a consistent error?

@Arch222
Copy link
Contributor

Arch222 commented Dec 14, 2021

Also, the 'show results' tab does not show anything.

@ChoiceCoin
Copy link
Owner

I added the original AlphaVote1, so we can integrate the previous functionality with @fionnachan's design.

@ChoiceCoin
Copy link
Owner

Also, @Arch222 is there an error readout? What troubleshooting have you tried?

@fionnachan fionnachan deleted the fionnachan/refinement_bash branch December 20, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants