Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen Support? #183

Open
josswright opened this issue Apr 5, 2024 · 4 comments · May be fixed by #184
Open

Fullscreen Support? #183

josswright opened this issue Apr 5, 2024 · 4 comments · May be fixed by #184
Labels
enhancement New feature or request

Comments

@josswright
Copy link

Is your feature request related to a problem? Please describe.

Not a problem, and I'm still convinced I might be missing this option, but it would be amazing to allow the window to take over the entire screen. (I'm in Windows 11, but obviously supporting this in Mac and Linux would be fantastic.)

Describe the solution you'd like
A fullscreen mode. Either a 'windowed fullscreen' or a true fullscreen, depending on whichever is easiest with the current codebase.

Describe alternatives you've considered
I can't see the ability to resize the window at present, so the only alternative right now is to have a smaller window in the middle of my larger monitor!

@josswright josswright added the enhancement New feature or request label Apr 5, 2024
@micheldebree micheldebree linked a pull request Apr 6, 2024 that will close this issue
6 tasks
@micheldebree micheldebree linked a pull request Apr 6, 2024 that will close this issue
6 tasks
@micheldebree
Copy link
Collaborator

micheldebree commented Apr 6, 2024

Hi Joss, I have hacked a version to always be in fullscreen, could you give it a try?

The Windows binary can be downloaded from https://github.com/Chordian/sidfactory2/actions/runs/8579409321/artifacts/1390488168 (need to be logged in to Github)

There is in fact a way to scale the window in the current version using the user.ini file. Here's a snippet from mine:

Window.Scaling = 1.2
Window.Scaling.Smooth = 1

@josswright
Copy link
Author

That's fantastic! Works for me here from a quick initial look.

One thing I did notice was that pressing F12 to get to the overlay(?) view didn't seem to work initially. I then tabbed away from the window, and when I came back the overlay was being displayed correctly. The same trick worked for turning off the overlay view -- it didn't initially work until I tabbed away from the window and then back.

Thanks for such a quick reply!

@micheldebree
Copy link
Collaborator

Thanks for having a look. I noticed mouse support is also not working properly, so that has to be fixed before we can release it. Check out the pull request here: #184

@micheldebree
Copy link
Collaborator

micheldebree commented Apr 6, 2024

Fixed the mouse scaling with the use of https://wiki.libsdl.org/SDL2/SDL_RenderWindowToLogical
But this requires SDL2 >= 2.0.18
MacOS version is at 2.0.14
Windows is at 2.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants