Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This library was already on Github #13

Open
softegg opened this issue Jun 28, 2017 · 6 comments
Open

This library was already on Github #13

softegg opened this issue Jun 28, 2017 · 6 comments

Comments

@softegg
Copy link

softegg commented Jun 28, 2017

This library already lives on Github here:
https://github.com/Nullkraft/Keypad

Your fork is missing some of the later revisions I made for handling multiple keys down for real-time stuff by adding state information to the event handler.

@DRSDavidSoft
Copy link

@softegg I think the version at @Nullkraft should be merged here, because:

  1. This repo has (more) active development
  2. It's linked on the official Arduino page

I'll create a pull request, if @Chris--A approves.

@Chris--A
Copy link
Owner

@DRSDavidSoft, go for it. This repo is here for the community.

@jamesmyatt
Copy link

This repo appears to be inactive (last commit was 5 years ago). Maybe it's better to use the Nullkraft repo now, which is ahead of this one anyway.

@Nullkraft
Copy link

This existence of this repo is partly my fault. Early on, when the Arduino teams were fighting internally, they locked the playground for quite some time. I ended up supporting requests for help directly through email so it made it seem as though there was no activity. I admit that I hoped this repo could become the default because I didn't want to fight for control over the URL link used by the Arduino Library Manager.

Chris--A, please let me know if you are against updating the Arduino Library Manager to point to my Nullkraft repo.

@DRSDavidSoft
Copy link

@Nullkraft Glad that the internal fight is now long over. Did you develop this library? Or rather maintain it?

Will you be willing to merge pull requests in here:
https://github.com/Chris--A/Keypad/pulls

And also some commits that @Chris--A initially did here?
https://github.com/Chris--A/Keypad/commits/master

@Nullkraft
Copy link

If I understand correctly you are asking if I would be willing to accept the same pull requests at Nullkraft/Keypad? If so then yes, I never stopped supporting the Keypad library.
I was the original author of the library but I only took it as far as the state-machine control. Alexander, a real programmer, later added the keypad event routines among other things. Alexander moved on to working with Wiring which is the upstream language that Arduino IDE uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants