Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null is rendered at the first line in JS when header field is left blank #34

Closed
jepsar opened this issue Mar 2, 2018 · 2 comments
Closed
Assignees
Milestone

Comments

@jepsar
Copy link

jepsar commented Mar 2, 2018

When I enter something like // in the header field, it is reflected on the first line.

Might relate to #14

@Chris2011 Chris2011 added this to To do in Minifierbeans Dec 18, 2018
@Chris2011 Chris2011 moved this from To do to Done in Minifierbeans Dec 18, 2018
@Chris2011 Chris2011 removed this from Done in Minifierbeans Dec 18, 2018
@Chris2011 Chris2011 self-assigned this Mar 31, 2019
@Chris2011 Chris2011 added this to To do in Minifierbeans via automation Mar 31, 2019
@Chris2011 Chris2011 added this to the 2.3.0 milestone Mar 31, 2019
@Chris2011
Copy link
Owner

Hey @jepsar can you please be more specific and maybe give a code sample? Will check it. Thx. I moved from YUICompressor to googl closure compiler. Maybe it will be fixed due to the switch but, to less information for that.

@Chris2011 Chris2011 moved this from To do to In Review in Minifierbeans Mar 31, 2019
@Chris2011
Copy link
Owner

Test code:

// Test.

Output:

'use strict';

So I couldn't see any problems here, only that it will always added use strict, but this will be another issue. So it seems to be fixed in 2.4.0.

Minifierbeans automation moved this from In Review to Done Apr 1, 2019
@Chris2011 Chris2011 modified the milestone: 2.4.0 Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Minifierbeans
  
Done
Development

No branches or pull requests

2 participants