Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKS converter name swapped to "USI_Converter" #122

Closed
LouisCyfer opened this issue Apr 15, 2020 · 4 comments
Closed

MKS converter name swapped to "USI_Converter" #122

LouisCyfer opened this issue Apr 15, 2020 · 4 comments
Assignees
Labels
next version fixed and will be deployed in next version testing

Comments

@LouisCyfer
Copy link

Please make sure you have the right converter replaced in NFElectricalUSIReactors.cfg the latest version of MKS (state of writing version 1.3.0.0) has different converter modules named "USI_Converter" instead of "ModuleResourceConverter". However, I'm unsure if this will change but writing a small script helped getting off the double-reactor controls while it looks like it removes the correct converter modules.

@PART[Tundra_PDU,Duna_PDU,USI_Nuke_*,FTT_Service_375_01,FTT_Reactor_500_01]:HAS[@MODULE[USI_Converter]]:NEEDS[MKS&NearFutureElectrical]:FINAL
{
	!MODULE[USI_Converter]{}
}

You might want to add :NEEDS[MKS] at each @PART-line aswell to make sure it only applies to the parts when MKS is installed/found.

Thanks for your work!

@LouisCyfer LouisCyfer changed the title MKS converter name swaped to "USI_Converter" MKS converter name swapped to "USI_Converter" Apr 15, 2020
@Wyzard256
Copy link
Contributor

This looks like the right thing to do, but instead of adding the patch above as a new file, it'd make more sense to incorporate the change directly into NFElectricalUSIReactors.cfg. Remove the !MODULE[ModuleResourceConverter]{} or !MODULE[ModuleResourceConverter_USI]{} for the affected parts, and add the !MODULE[USI_Converter]{} line instead.

@LouisCyfer
Copy link
Author

The temp config I wrote was to verify functionality in first place, no worries. Love to see the NF-line evolving!

@ChrisAdderley ChrisAdderley self-assigned this May 5, 2020
@ChrisAdderley ChrisAdderley added next version fixed and will be deployed in next version testing labels May 5, 2020
@ChrisAdderley
Copy link
Collaborator

Fix is ready in dev, will be in next release

@ChrisAdderley
Copy link
Collaborator

Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next version fixed and will be deployed in next version testing
Projects
None yet
Development

No branches or pull requests

3 participants