Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control doesn't behave like other built-in controls #4

Closed
Triangle333 opened this issue Apr 20, 2020 · 6 comments
Closed

Control doesn't behave like other built-in controls #4

Triangle333 opened this issue Apr 20, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@Triangle333
Copy link

Triangle333 commented Apr 20, 2020

  1. Control doesn't respect "Number of Rows" setting (Formatting tab) and its height grows with content. Minor issue and I understand that this is probably impossible to implement...
  2. Control doesn't support disabling. BIG issue, especially for Inactive records (it is still possible to change & save data in this control even if the entire form is disabled). PCF supports this - please implement.
@ChrisMayor ChrisMayor added the bug Something isn't working label Apr 20, 2020
@ChrisMayor
Copy link
Owner

Hello,
I will have a look at this in the next days.

@walkerjono
Copy link

walkerjono commented Apr 25, 2020

Control doesn't respect "Number of Rows" setting (Formatting tab) and its height grows with content. Minor issue and I understand that this is probably impossible to implement...

It would be great to be able to set a min-height for the control and for it to auto expand if the content is longer than the min-height

@ChrisMayor ChrisMayor self-assigned this Apr 25, 2020
@ChrisMayor
Copy link
Owner

Hello,

  1. I added the suggestion from walterjono now with version 2.1 it is now possible to enter parameters "height, min-height, max-height" in pixels at the customizing of the control. If no values are entered the control will size to 200px by default. Now the control behaves like other dynamics controls. I will document this in the readme.md later.

  2. Is in parts now implemented, if you open a deactivated form the control is deactivated. But if you deactivate the current form without reopening it currently not works in 2.1 ... I will now have a look at it and will fix this now

@ChrisMayor
Copy link
Owner

Thank you for your suggestions and issues.

I was able to fix 2) now very quickly ;-) ... please update to latest solution 2.2

@walkerjono
Copy link

Awesome, thanks!

@Triangle333
Copy link
Author

Thanks! Our QA is happy now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants