fix: more renames

ChrisTowles · Sep 29, 2022 · 1a6fe47 · 1a6fe47
1 parent 82ecf93
commit 1a6fe47
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -10,9 +10,16 @@
 -->
 </p>
 
+## Requirements
+
+- `xclip` command be required (Linux)
+- `powershell` command be required (Win32)
+- `pbpaste` command be required (Mac)
+
 <p align="center">
 Smart selection with double clicks for VS Code.<br>
 
+</p>
 `// TODO GIF`
 
 ## Usage

diff --git a/src/configuration.spec.ts b/src/configuration.spec.ts
@@ -14,7 +14,6 @@ describe('Configuration', () => {
 
     it('check parse of default values', async () => {
 
-
         const config = await parseConfigurationToConfig({
             projectRootDirPath: __dirname,
             editorOpenFilePath: __filename,

diff --git a/src/configuration.ts b/src/configuration.ts
@@ -10,7 +10,7 @@ export interface Configuration {
     readonly imageFolderPath: string;
 
 
-    readonly insertPatternConfig: string;
+    readonly insertPattern: string;
     readonly showFilePathConfirmInputBox: boolean,
     readonly filePathConfirmInputBoxMode: FilePathConfirmInputBoxModeEnum;
     readonly encodePath: EncodePathEnum;
@@ -51,7 +51,7 @@ export const parseConfigurationToConfig = async ({ projectRootDirPath, editorOpe
 
 
     let encodePath = configuration.get<EncodePathEnum>(Constants.Config_EncodePath, EncodePathEnum.UrlEncodeSpace);
-    let insertPatternConfig = configuration.get<string>(Constants.Config_InsertPattern, '');
+    let insertPattern = configuration.get<string>(Constants.Config_InsertPattern, '');
 
 
     let imageUriPathPrefix = configuration.get<string>(Constants.Config_ImageUriPathPrefix, '');
@@ -73,7 +73,7 @@ export const parseConfigurationToConfig = async ({ projectRootDirPath, editorOpe
     imageFolderPath = replacePathVariable({ pathStr: imageFolderPath, projectRootDirPath: projectRootDirPath, editorOpenFilePath: editorOpenFilePath });
     imageNamePrefix = replacePathVariable({ pathStr: imageNamePrefix, projectRootDirPath: projectRootDirPath, editorOpenFilePath: editorOpenFilePath });
     imageNameSuffix = replacePathVariable({ pathStr: imageNameSuffix, projectRootDirPath: projectRootDirPath, editorOpenFilePath: editorOpenFilePath });
-    insertPatternConfig = replacePathVariable({ pathStr: insertPatternConfig, projectRootDirPath: projectRootDirPath, editorOpenFilePath: editorOpenFilePath });
+    insertPattern = replacePathVariable({ pathStr: insertPattern, projectRootDirPath: projectRootDirPath, editorOpenFilePath: editorOpenFilePath });
 
 
     const config: Configuration = {
@@ -84,7 +84,7 @@ export const parseConfigurationToConfig = async ({ projectRootDirPath, editorOpe
 
         encodePath: encodePath,
 
-        insertPatternConfig: insertPatternConfig,
+        insertPattern: insertPattern,
         showFilePathConfirmInputBox: showFilePathConfirmInputBox,
         filePathConfirmInputBoxMode: filePathConfirmInputBoxMode,
 

diff --git a/src/folderUtil.spec.ts b/src/folderUtil.spec.ts
@@ -34,7 +34,7 @@ describe('FolderUtil', () => {
             // clean up created folder
             let folderStat = await fse.stat(testDir)
             if (folderStat.isDirectory()) {
-                await fse.rmdir(testDir, { recursive: true });
+                await fse.rm(testDir, { recursive: true });
             }
         })
     });

diff --git a/src/renderTextWithImagePath.ts b/src/renderTextWithImagePath.ts
@@ -34,7 +34,7 @@ const PATH_VARIABLE_IMAGE_SYNTAX_SUFFIX = /\$\{imageSyntaxSuffix\}/g;
 
 export const renderTextWithImagePath = async ({ languageId, config, imageFilePath, logger }: { languageId: string; config: Configuration; imageFilePath: string; logger: ILogger; }): Promise<string> => {
 
-    logger.debug(`renderFilePath start - ${imageFilePath}`);
+    // logger.debug(`renderFilePath start - ${imageFilePath}`);
 
     imageFilePath = await getRelativePathFromEditorFile({ editorOpenFolderPath: config.editorOpenFolderPath, imageFilePath, logger });
     let originalImagePath = imageFilePath;
@@ -55,13 +55,13 @@ export const renderTextWithImagePath = async ({ languageId, config, imageFilePat
             imageSyntaxPrefix = `![](`
             imageSyntaxSuffix = `)`
             break;
-        case "asciidoc":
-            imageSyntaxPrefix = `image::`
-            imageSyntaxSuffix = `[]`
+        // todo add html and other image syntax
+        default:
+            // do default
             break;
     }
 
-    let result = config.insertPatternConfig
+    let result = config.insertPattern
     result = result.replace(PATH_VARIABLE_IMAGE_SYNTAX_PREFIX, imageSyntaxPrefix);
     result = result.replace(PATH_VARIABLE_IMAGE_SYNTAX_SUFFIX, imageSyntaxSuffix);
 
@@ -70,7 +70,7 @@ export const renderTextWithImagePath = async ({ languageId, config, imageFilePat
     result = result.replace(PATH_VARIABLE_IMAGE_FILE_NAME, fileName);
     result = result.replace(PATH_VARIABLE_IMAGE_FILE_NAME_WITHOUT_EXT, fileNameWithoutExt);
 
-    logger.debug('renderFilePath end');
+    // logger.debug('renderFilePath end');
     return result;
 }