Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1 : Initialize project with components (React only). #2

Merged
merged 9 commits into from Jul 8, 2022

Conversation

Chrissiku
Copy link
Owner

What I add to the project πŸ’»

in this project's Milestone I lay foundations of the Bookstore website. I create the React part of the app and I also set up routing using React Router.

What I use πŸ‘¨β€πŸ’»

  • React Router.
  • React Components

What I implement ♻️

  • Initialise React app.
  • Set as re-usable components
  • Add React Router and set two <Route>s and <Link>s for the app's navigation

Technology used πŸ§‘β€πŸ’»

  • Language : JavaScript(ES6), JSX and CSS3
  • Framework: None
  • Library: Reactjs
  • Module bundler : Babel
  • Technology: Gitflow, Github Workflow, Linters

Project New Overview

book

Copy link

@aimemalaika aimemalaika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Chrissiku,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

133591850-fdcb7dd3-dd7a-4274-81e7-0e59434148f7

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment on lines 7 to 29
<>
<div className="book">
<div className="left-book">
<span className="type">Action</span>
<h3>The Hunger Games</h3>
<span className="author">Suzanne Collins</span>
<ul>
<li>
<a>Comments</a>
</li>
<li>
<a>Remove</a>
</li>
<li>
<a>Edit</a>
</li>
</ul>
</div>

<div className="right-book">
<div className="progress">
<div className="circle">
<div className="inner"></div>
Copy link

@aimemalaika aimemalaika Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Kindly make sure that the book component has the two required props title and author

Copy link

@OmarRamoun OmarRamoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟒 Project Approved! πŸ†

Hi @Chrissiku πŸ‘‹

Your project is complete! βœ”οΈ 🏁

Finally, you did it! πŸŽ‰ πŸ‘. Your code was very professional πŸ’― and I can see you have a great chance to be a Great Software Engineer ⛑️.

There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰. And Welcome to Microverse πŸ‘‹.

Note: You can now take a break even if short before you move on to the next project. Happy πŸ˜„ Coding πŸ–₯️! and Have a nice day 🌞.

Highlights 🌟

  • βœ”οΈ Descriptive commmit messsages
  • βœ”οΈ Descriptive PR description
  • βœ”οΈ No linter Errors
  • The code is top-notch! πŸ’― and have a huge potential.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Important Notes πŸ“

  • Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
  • Please, remember to tag me in your question so I can receive the notification.

Thank you for your time πŸ™ and call me if you need help or clarification ☎️

  • This is My GitHub: @omarramoun
  • This is My Twitter: @omarramoun
  • This is My Slack: Ramoun

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Chrissiku
Copy link
Owner Author

Thank you @OmarRamoun for the approval of the project

@Chrissiku Chrissiku merged commit c45c436 into development Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants