Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3 : Final touches #3

Merged
merged 2 commits into from Jun 16, 2022
Merged

Milestone 3 : Final touches #3

merged 2 commits into from Jun 16, 2022

Conversation

Chrissiku
Copy link
Owner

Changes Description πŸ“„

As I have a fully working app that uses only basic styles to make the layout work, according to the below wireframe: in this project's milestone I add some styling to the user interface for a better user experience

wireframe

What I add to the project ♻️

  • adding the styles,
  • improve the look and feel of the application,

Technology used πŸ§‘β€πŸ’»

  • Language: JavaScript , HTML & CSS
  • Module Bundler : Webpack
  • Framework : nome
  • Library: none
  • Technology : Github, Git, Linters, and API

Copy link

@prolajumokeoni prolajumokeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Chrissiku,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

Highlights

  • No linter errors βœ…
  • Git flow was used correctly πŸš€
  • Good design πŸ’―
  • Good Pr title and description πŸ’ͺ🏿

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • N/A

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Chrissiku
Copy link
Owner Author

Thank you @prolajumokeoni

@Chrissiku Chrissiku merged commit 7885579 into dev Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants