Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3: Basic structure af the app and Rockets reducer #27

Merged
merged 5 commits into from Jul 18, 2022

Conversation

Chrissiku
Copy link
Owner

What I add ♻️

In this project's milestone I create :

  • A basic structure of the Rockets reducer,
  • An empty Rockets component
  • An empty Missions component
  • An empty Profile component
  • A store configured for the app

Technology used 🧑‍💻

  • Language : JSX, JavaScript(ES6) and CSS3
  • Framework and Library: React-bootstrap, React, Redux, React-redux
  • Technology: Git, Gitflow, GitHub

Copy link
Collaborator

@Graycemuthui Graycemuthui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Chrissiku ,

✔️ Basic structure is well setup
✔️ Use of proper Gitflow
✔️ No linter errors

STATUS: APPROVED! 🥇 💯

done

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

@Chrissiku
Copy link
Owner Author

Thank you @Graycemuthui,
I'm just done with fetching data from the API, I'm going to work on few things again then push for a new pull request.

@Chrissiku Chrissiku merged commit 53d6466 into dev Jul 18, 2022
@Chrissiku Chrissiku deleted the basic-structure-rocket branch August 15, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants