Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milesotne 2 : Add, remove and edit items #2

Merged
merged 2 commits into from Jun 2, 2022
Merged

Conversation

Chrissiku
Copy link
Owner

What I add to project ♻️

For this project's milestone I Add the following functionalities to the project :

  • Remove all hardcoded items from the tasks array.
  • Create a new JavaScript file for the new functionality.
  • Implement a function for adding a new task (add a new element to the array).
  • Implement a function for deleting a task (remove an element from the array).
  • implement a function for editing task descriptions.

Note that: all changes to the project are stored in the localStorage;

Technology 🧑‍💻

  • Language : Javascript, HTML and CSS
  • Framework: none
  • Module Bundler: Webpack
  • Technology : Github, Git, Linters

Copy link

@prolajumokeoni prolajumokeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Chrissiku,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors ✅
  • Github flow was used correctly 🚀
  • Good design 💯
  • Good Pr title and description 💪🏿

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Chrissiku
Copy link
Owner Author

Thank you @prolajumokeoni

@Chrissiku Chrissiku merged commit 7f38571 into main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants