Jest testing for add and remove function for todo-list app #9
Conversation
There was a problem hiding this comment.
Hi @Christabelle143 and @mirwaisfarahi 😃, 👋,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- There are no linter errors ✔️
- You have a descriptive PR ✔️
Required Changes ♻️
- It would be preferable if your README included instructions on how users can run the tests locally.
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/addremoveedit.js
Outdated
| // export function removeone(element) { | ||
| // console.log(element.parentNode.id) | ||
| // const todolist = load(); | ||
| // const index = element.parentNode.id; | ||
| // todolist.splice(index, 1); | ||
| // save(todolist); | ||
| // return todolist; | ||
| // } |
There was a problem hiding this comment.
- Please do not commit old pieces of code as inline comments. They will make your project look messy. If you need to review a previous version of your code, you can always use git history.
src/addremoveedit.js
Outdated
| // const index = id; | ||
| // console.log(typeof(id)); | ||
| todolist.splice(id, 1); | ||
| // console.log(todolist.length) |
There was a problem hiding this comment.
- Please remove the commented code to keep your code clean.
src/index.js
Outdated
| // console.log(i) | ||
| todolist = removeone(trash.parentNode.id); | ||
| // todolist = removeone(i); | ||
| ShowAll(todoDiv); | ||
| window.location.reload(); | ||
| // window.location.reload(); |
There was a problem hiding this comment.
- Please remove the commented code to keep your code clean.
There was a problem hiding this comment.
Status: Approved ✔️ ✔️ ✔️
Hi team 👏🏾
Your project is complete! Great job for making the requested changes 🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 
. Congratulations! 🎉💯🌟
Good Points 👍
- Descriptive Pull Request✔️
- todolist adds and removes✔️
- jest test passed✔️
- No linter errors ✔️
# Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.
In this project my partner and I;