Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null is a valid resultpath #107

Merged
merged 3 commits into from Aug 25, 2022

Conversation

pwtyler
Copy link
Contributor

@pwtyler pwtyler commented Aug 20, 2022

Closes #106. Treats a ResultPath of null as valid schema. New to the refactored version here so please offer corrections where needed.

Comment on lines 9 to 12
"asl_ref_path": {
"type": "string",
"type": ["string", "null"],
"format": "asl_ref_path"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the ResultPath but I think you'd also need to change the asl_path type above this. This is the type that's used for InputPath and OutputPath.

I would expect your test file "valid-null-input.json" would report an error until the "asl_path" also allows for null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I was messing with the files after the fact and pushed the wrong version— I had meant to test InputPath: null be invalid and I was making sure I was understanding what I was doing with asl_ref_path, but I just checked in the AWS console to be sure, and InputPath: null is valid, which makes sense once I think about it a little further.

@ChristopheBougere ChristopheBougere merged commit 48bdf51 into ChristopheBougere:main Aug 25, 2022
@github-actions
Copy link

🎉 This PR is included in version 3.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pwtyler pwtyler deleted the bug-106 branch August 29, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null is no longer a valid ResultPath
3 participants