Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child Theming #9

Closed
ChristopherBiscardi opened this issue Dec 6, 2018 · 3 comments
Closed

Child Theming #9

ChristopherBiscardi opened this issue Dec 6, 2018 · 3 comments
Labels
core Something that need to happen in the gatsby multi-package repo

Comments

@ChristopherBiscardi
Copy link
Owner

Currently the theme composition algorithm only supports the user's site as a "child theme". We need to make the algorithm recurse so that themes can specify parents. In the following example, the user's site specifies gatsby-theme-blog-red as a theme, and gatsby-theme-blog-red specifies gatsby-theme-blog.

gatsby-theme-blog -> gatsby-theme-blog-red -> user's site

This will encourage people to build on top of core themes, sharing data and other attributes.
@ChristopherBiscardi ChristopherBiscardi added the core Something that need to happen in the gatsby multi-package repo label Dec 6, 2018
@ChristopherBiscardi
Copy link
Owner Author

ChristopherBiscardi commented Dec 21, 2018 •
edited

This is pretty much done. PR soon. No breaking changes to the way composition works.

@ChristopherBiscardi ChristopherBiscardi mentioned this issue Dec 21, 2018
Closed
@ChristopherBiscardi
Copy link
Owner Author

this will be closed by gatsbyjs/gatsby#10787

@ChristopherBiscardi
Copy link
Owner Author

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Something that need to happen in the gatsby multi-package repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChristopherBiscardi