Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a button in the About Us page to navigate back to the Home page #118

Closed
wants to merge 1 commit into from
Closed

Add a button in the About Us page to navigate back to the Home page #118

wants to merge 1 commit into from

Conversation

TBorundia
Copy link
Contributor

PR Description 📜

I have added the button in about us page to navigate to home page, with CSS
fixed #109

Mark the task you have completed ✅

  • [ ✅] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [✅ ] I have performed a self-review of my own code or work.
  • [✅ ] I have commented my code, particularly in hard-to-understand areas.
  • [✅ ] My changes generates no new warnings.
  • [✅ ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [ ✅] I have added screenshot for review.
## Add your screenshots(Optional) 📸 ![image](https://github.com/GameSphere-MultiPlayer/Physi-c-Tech/assets/168854094/78d106d8-9e1c-4a8c-8c85-bd3af01a50a9)

Thank you soo much for contributing to our repository 💗

@thevirengarg
Copy link
Collaborator

@TBorundia Add screen recording to the PR description for review.

@TBorundia
Copy link
Contributor Author

Uploading Button for navigation.mp4…

@TBorundia
Copy link
Contributor Author

@thevirengarg , Sir why this code is not merged?

ButtonNavigation.mp4

@thevirengarg
Copy link
Collaborator

@TBorundia Please stop spamming. You are creating unnecessary issues, for which I can't even give you level1 tag. You won't get anything by tagging me again and again.

These are the issue:

  1. Home button is never on right of the page.
  2. Code had conflicts in it.
  3. The designing of the button was not matching the theme.
  4. You didn't provide the screen recording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a button in the About Us page to navigate back to the Home page
2 participants
@TBorundia @thevirengarg