Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cilex/Silex ServiceProvider Incompatibility #48

Closed
jonmchan opened this issue Apr 12, 2014 · 3 comments
Closed

Cilex/Silex ServiceProvider Incompatibility #48

jonmchan opened this issue Apr 12, 2014 · 3 comments
Milestone

Comments

@jonmchan
Copy link

The register function of Cilex\Application supposedly allows you to register a Silex ServiceProvider (\vendor\cilex\cilex\src\Cilex\Application.php:97-99), but when actually trying to register the Silex ServiceProvider, you hit:

Catchable fatal error: Argument 1 passed to Igorw\Silex\ConfigServiceProvider::register() must be an instance of Silex\Application, instance of Cilex\Application given

If it is to be compatible with Silex service providers, the Interface definition typehint must be dropped or if it is not compatible, lines \vendor\cilex\cilex\src\Cilex\Application.php:97-103 should be removed.

This seems related to #3.

@mvriel
Copy link
Member

mvriel commented May 2, 2014

@jonmchan It is intended to migrate to a newer version of Pimple so that we can rely on the Pimple\ServiceProviderInterface. This will create a common ground. But for this to work we must check how badly this breaks BC

@mvriel mvriel added this to the 2.0 milestone May 11, 2014
@henrikbjorn henrikbjorn mentioned this issue Aug 26, 2014
@henrikbjorn
Copy link
Contributor

This is fixed in develop.

@mvriel
Copy link
Member

mvriel commented Oct 11, 2014

It is!

@mvriel mvriel closed this as completed Oct 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants