Add easy way to use simple closures as commands

[henrikbjorn]

This fixed #27

I know this is a BC but since it targets 2.0 i think it is okay.

The reason for renaming command to add is that it adds the command to the application, which is the same terminology used by a normal Console Application. Also when using closures the name command feels more natural.

here is an example, the syntax should be equal to the one used in Silex with its get, post etc functions.

<?php

$cilex = new Cilex\Application;
$cilex->command('my-command-name', function ($input, $output) {
    // do something
});

$command = $cilex->command('my-command-name', function ($input, $output) {
    // do something
});

$command->addOption(); // etc.

[mvriel]

Doesn't setCode only influence the execute method of a Command? Unless I got it wrong I am missing a way to add argument and option definitions and a way to set the description for a command

[henrikbjorn]

It does, thats why the created command object is returned from the function. Its a shortcut, not the "best" way to create full commands.

In silex binding would be

$app->get('/', function () {})->bind('route');

which is the same as cilex

$app->command('my-name', function () {
})->addOoption(); // etc.

[mvriel]

Interesting notion, I hadn't thought of that option. Awesome!

[mvriel]

I would merge this feature except that I am not entirely convinced of the 'add' method name. This is because add usually implies that you add something to the collection on which you invoke it and the Pimple\Container is a Dependency Injection Container.

Hence add suggests to me that you add a service to the container.

I don't have any other alternatives at hand quickly (except for the existing command).

Let's explore the names a bit; I will try to think of new ones. Do you have more suggestions?

[henrikbjorn]

maybe set i dunno.

I understand that think because Application extends pimple, but it is its own thing, and as Pimple only really expose offsetGet and offsetSet i think add() is a good enough compromise of keeping it intuiative for the end user to add a command and also not to confuse it (as you set services on a container, not add them).

[henrikbjorn]

should this be closed?