Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigServiceProvider missing #80

Open
pemedina opened this issue Jan 30, 2017 · 5 comments · May be fixed by #81
Open

ConfigServiceProvider missing #80

pemedina opened this issue Jan 30, 2017 · 5 comments · May be fixed by #81

Comments

@pemedina
Copy link

Wondering if ConfigServiceProvider is gone in develop branch ?
I can see it in 1.1.
Was it removed on purpose?

olorton added a commit to olorton/Cilex that referenced this issue Feb 25, 2017
olorton added a commit to olorton/Cilex that referenced this issue Feb 25, 2017
@olorton olorton linked a pull request Feb 25, 2017 that will close this issue
@olorton
Copy link

olorton commented Feb 25, 2017

I don't know the intent for removing this, but here's a PR to re-add it. I'll take a stab at updating the readme as well.

@Wirone
Copy link

Wirone commented Nov 10, 2017

AFAIS this provider was removed in #54, I don't know yet what is the current way of configuration since readme in 2.0.0 still contains ConfigServiceProvider usage reference. Today we wanted to bootstrap new simple app from other our project but wanted to upgrade Cilex and we are confused too with this change.

@Wirone
Copy link

Wirone commented Nov 10, 2017

@pemedina: @henrikbjorn's comment shows that igorw/ConfigServiceProvider can be used as replacement.

@pemedina
Copy link
Author

pemedina commented Nov 10, 2017

@Wirone , Thanks. Actually i solved this just implementing this provider manually:
screenshot 2017-11-10 a la s 11 26 12

, so in my app i use

$this->register( new ConfigServiceProvider(), ['config.path' => APP_PATH . "/config/$environment.yml" ] );
where ConfigServiceProvider is:
https://gist.github.com/pemedina/a2d620441586f12f639cb54d761e8f93

I'm aware that @igorw 's code has more features and i'l prolly use it. I just solved the issue this way.

@henrikbjorn
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants