Implement a function for clear all completed #3
Conversation
There was a problem hiding this comment.
Hi @CindyDorantes, 👋🏻👋🏻
Good job so far!🔥🔥🔥
Personally, I really appreciate your huge efforts but There are some issues that you still need to work on to go to the next project but you are almost there! so kindly Fix the error so we can proceed with your project.💯💯✨✨✅✅✅
Highlights ✨
- No Linters error ✅✅✅
- Good using filter method for clear all completed 🔥🔥
- Great on using modules🔥🔥
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/modules/completed.js
Outdated
| export default function () { | ||
| const tasksCompleted = document.querySelectorAll('.checked'); | ||
| const arrCompleted = [...tasksCompleted]; | ||
| for (let i = 0; i < arrCompleted.length; i += 1) { | ||
| arrCompleted[i].parentElement.remove(); | ||
| arrCompleted[i].nextElementSibling.remove(); | ||
| } | ||
| } |
There was a problem hiding this comment.
-
I think The complete is not toggling in the local storage from false to true, so kindly fix that since it is from the requirements.
-
After refreshing I can't see any tasks displayed in the list so kindly fix it🔥
There was a problem hiding this comment.
Hi, @CindyDorantes,
You've done well working on the concerns of the previous review 👍🏼.
The tasks for this milestone are now successfully implemented 💯.
Highlights
- Professional README ✔️
- Clean code ✔️
- Good commit messages ✔️
All the best with the next project.
You are free to merge this branch 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Project requirements
completed:true/false).change).completedkey upon user actions.filter()method).Second review request
Changes included: