New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript best practices. #4

Open

CindyDorantes opened this issue Jul 18, 2022 · 0 comments

Owner

CindyDorantes commented Jul 18, 2022

There are several functions in the class-task.js file, You could improve the readability moving code to new modules.

You could use conditional shorthands for the folloing lines of code inside class-task.js;

To-do-list/src/modules/class-task.js

Lines 23 to 25 in 9e4af80

    
           if (this.completed === true) { 
        
             taskCheck.checked = true; 
        
           }

To-do-list/src/modules/class-task.js

Lines 47 to 54 in 9e4af80

    
           taskCheck.addEventListener('change', () => { 
        
             if (taskCheck.checked === true) { 
        
               taskCheck.classList.add('checked'); 
        
               this.completed = true; 
        
             } else { 
        
               taskCheck.classList.remove('checked'); 
        
               this.completed = false; 
        
             }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment