Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer To Peer Code Review Morning Session #5

Open
Krishnabot opened this issue Jul 28, 2022 · 0 comments
Open

Peer To Peer Code Review Morning Session #5

Krishnabot opened this issue Jul 28, 2022 · 0 comments

Comments

@Krishnabot
Copy link

Krishnabot commented Jul 28, 2022

Great Project and great effort 馃煝 馃煝 馃煝

  • We would suggest using imperative tense to write js comments. it is the standard practice.
  • instead of repeating the same work ( getting and setting Local storage) over and over again, you can set up a method to get and set local storage once and whenever needed call those methods.
  • Implementing adding tasks with entering the keyboard would increase the functionality of your app, please consider.
  • using the focus property to delete icon to appear might confuse the user since you need to click on the element to delete an icon from appearing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant