Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest boost 1.55 #3

Closed
doomhz opened this issue May 23, 2014 · 2 comments
Closed

Upgrade to latest boost 1.55 #3

doomhz opened this issue May 23, 2014 · 2 comments
Assignees

Comments

@doomhz
Copy link

doomhz commented May 23, 2014

Hey,

We're trying to add Cinni on CoinNext (coinnext.com) but we are having troubles compiling the wallet from source. Could you please upgrade the code to be compatible with the latest boost library please? It's 1.55 atm. Otherwise, it brakes the source compilation:

json/json_spirit_writer_template.h: In function 'String_type json_spirit::non_printable_to_string(unsigned int)':
json/json_spirit_writer_template.h:31:50: warning: typedef 'Char_type' locally defined but not used [-Wunused-local-typedefs]
         typedef typename String_type::value_type Char_type;
                                                  ^
g++ -c -O2 -msse2 -pthread -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -g -DBOOST_SPIRIT_THREADSAFE -I/home/ubuntu/coins/CinniCoin/src -I/home/ubuntu/coins/CinniCoin/src/obj -DUSE_UPNP=0 -DUSE_IPV6=1 -DHAVE_BUILD_INFO -fno-stack-protector -fstack-protector-all -Wstack-protector -D_FORTIFY_SOURCE=2  -MMD -MF obj/rpcrawtransaction.d -o obj/rpcrawtransaction.o rpcrawtransaction.cpp
In file included from bitcoinrpc.h:16:0,
                 from rpcrawtransaction.cpp:9:
json/json_spirit_writer_template.h: In function 'String_type json_spirit::non_printable_to_string(unsigned int)':
json/json_spirit_writer_template.h:31:50: warning: typedef 'Char_type' locally defined but not used [-Wunused-local-typedefs]
         typedef typename String_type::value_type Char_type;
                                                  ^
g++ -c -O2 -msse2 -pthread -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -g -DBOOST_SPIRIT_THREADSAFE -I/home/ubuntu/coins/CinniCoin/src -I/home/ubuntu/coins/CinniCoin/src/obj -DUSE_UPNP=0 -DUSE_IPV6=1 -DHAVE_BUILD_INFO -fno-stack-protector -fstack-protector-all -Wstack-protector -D_FORTIFY_SOURCE=2  -MMD -MF obj/script.d -o obj/script.o script.cpp
g++ -c -O2 -msse2 -pthread -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -g -DBOOST_SPIRIT_THREADSAFE -I/home/ubuntu/coins/CinniCoin/src -I/home/ubuntu/coins/CinniCoin/src/obj -DUSE_UPNP=0 -DUSE_IPV6=1 -DHAVE_BUILD_INFO -fno-stack-protector -fstack-protector-all -Wstack-protector -D_FORTIFY_SOURCE=2  -MMD -MF obj/sync.d -o obj/sync.o sync.cpp
g++ -c -O2 -msse2 -pthread -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -g -DBOOST_SPIRIT_THREADSAFE -I/home/ubuntu/coins/CinniCoin/src -I/home/ubuntu/coins/CinniCoin/src/obj -DUSE_UPNP=0 -DUSE_IPV6=1 -DHAVE_BUILD_INFO -fno-stack-protector -fstack-protector-all -Wstack-protector -D_FORTIFY_SOURCE=2  -MMD -MF obj/util.d -o obj/util.o util.cpp
util.cpp: In function 'long int hex2long(const char*)':
util.cpp:493:43: warning: array subscript has type 'char' [-Wchar-subscripts]
   ret = (ret << 4) | hextable[*hexString++];
                                           ^
g++ -c -O2 -msse2 -pthread -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter -g -DBOOST_SPIRIT_THREADSAFE -I/home/ubuntu/coins/CinniCoin/src -I/home/ubuntu/coins/CinniCoin/src/obj -DUSE_UPNP=0 -DUSE_IPV6=1 -DHAVE_BUILD_INFO -fno-stack-protector -fstack-protector-all -Wstack-protector -D_FORTIFY_SOURCE=2  -MMD -MF obj/wallet.d -o obj/wallet.o wallet.cpp
wallet.cpp: In member function 'bool CWallet::AddToWallet(const CWalletTx&)':
wallet.cpp:493:13: error: 'replace_all' is not a member of 'boost'
             boost::replace_all(strCmd, "%s", wtxIn.GetHash().GetHex());
             ^
make: *** [obj/wallet.o] Error 1

Thanks!

@rynomster
Copy link
Collaborator

We're boost 1.54 compatible.
We will look at this in the near future

@rynomster rynomster self-assigned this Jun 14, 2014
@rynomster
Copy link
Collaborator

Made it work with boost 1.55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants