Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal volume control on Android app #8

Closed
emlopes opened this issue Jul 16, 2022 · 2 comments · Fixed by #9
Closed

Universal volume control on Android app #8

emlopes opened this issue Jul 16, 2022 · 2 comments · Fixed by #9
Assignees
Labels
enhancement New feature or request

Comments

@emlopes
Copy link

emlopes commented Jul 16, 2022

It would be very useful to have a universal volume control so I could keep the same mix but reduce the volume globally.

Of course I could use the android system volume control, but that doesn't work if I'm also playing audio from other apps at the same time.

@Ciock Ciock added the enhancement New feature or request label Jul 16, 2022
@Ciock
Copy link
Owner

Ciock commented Jul 16, 2022

I would place the volume slider under the global play/pause button. To gain some space, I think we can remove the phrase on top that is not necessary.

To make it clear, to me the behavior should be that the global volume slider adjusts others, but doesn't set them to its value. For example:

Song A playing at 50%, and song B playing at 100%. Then I set the global volume slider at 50%, the songs relative slider doesn't change in UI, but A will play at 25% and B at 50%.

x49kpsge91d51

@Ciock Ciock self-assigned this Jul 18, 2022
@Ciock Ciock linked a pull request Jul 18, 2022 that will close this issue
@Ciock Ciock closed this as completed in #9 Jul 18, 2022
@Ciock
Copy link
Owner

Ciock commented Jul 18, 2022

It's under review by Google, it'll be out in a couple of hours 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants