Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.0 includes breaking changes from 4.0.0 #156

Closed
nicolaschambrier opened this issue Sep 4, 2023 · 2 comments · Fixed by #159
Closed

4.1.0 includes breaking changes from 4.0.0 #156

nicolaschambrier opened this issue Sep 4, 2023 · 2 comments · Fixed by #159
Assignees

Comments

@nicolaschambrier
Copy link

nicolaschambrier commented Sep 4, 2023

In 4.1.0 a change has been made which is totally not backward-compatible:

  • aws_access_key_id used to be an environment variable name while it's now expected to be the value
  • same for aws_secret_access_key
  • The descriptions for those two parameters did not change, it still says "... Set this to the name of the environment variable ..." which is incorrect

I think this version should be dropped and re-released as 5.0.0 (with updates to the description) as marking this as a minor change could break a lot of workflows, or at least fix the descriptions so that the public manual is correct.

@brivu
Copy link
Contributor

brivu commented Sep 7, 2023

Hey @nicolaschambrier, thanks for letting us know. I'm going to get a fix out for this today that should work if you have them stored as environment variables

@brivu brivu linked a pull request Sep 8, 2023 that will close this issue
@brivu
Copy link
Contributor

brivu commented Sep 8, 2023

This has been fixed with PR #159. I removed the $ and changed the way we expand that variable in the script and it works. Please let me know if you encounter something different. Thanks!

@brivu brivu closed this as completed Sep 8, 2023
@brivu brivu self-assigned this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants