-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout step of build fails after release on 19 May 2022 #170
Comments
@JalexChen are you able to take a look at this? A quick fix would be to tag the second most recent commit to main as 'monthly' and push it up. Assuming you find an issue with this release |
It is related to a vulnerability fix in GIT: Github actions had to make adjustments to fix their checkout step. It was reported on CircleCI discuss about a month ago, but it looks like nobody took note: What is your process around testing these |
So this then isn't a regression in the image so to speak. Setting a working_directory outside of In the meantime, possible solutions forward here:
As for testing, we have some testing in this repository and some in external repositories. We are gearing up to quadruple down on the amount of testing that all images under I'm going to keep this issue open to track the git behavior change request. |
The CircleCI documentation explicitly suggests using So how is it no regression that official CircleCI images don't work with suggested configuration? |
If you want to use that feature yes. It doesn't say it works with a Convenience Image. Even in the example provided in that doc it uses the Docker Library
We shipped an updated version of As I mentioned above, I've been following this. Git introduced a config flag to add individual directories to be ignored by this new security feature. Then, in a version of git newer than what the May update provides, they allow an In the meantime, you can run the following in your config BEFORE - run: git config --global --add safe.directory '*'
# or
- run: git config --global --add safe.directory '/mnt/ramdisk'
- checkout I hope that helps. |
Our build started failing after the latest release a few hours ago of
cimg/base:current
.It is failing on the
checkout
step:Here are the steps in this job that get to this point:
How do you suggest we resolve this issue?
Are we doing something wrong in our job, or is there a bug in this release?
Environment Details
Environment details from "Spin up environment" step:
It worked a few hours ago when based on
cimg/base@sha256:a394761a8abe3dbb25170529be8687c5d47eea2cbe118e37a7b49adb48692d45
The text was updated successfully, but these errors were encountered: