Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS install compatibility. #5

Closed
KyleTryon opened this issue Jun 27, 2019 · 7 comments
Closed

MacOS install compatibility. #5

KyleTryon opened this issue Jun 27, 2019 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@KyleTryon
Copy link
Contributor

Orb version

What happened

@ganezasan has found that the Yarn install incorrectly installs under MacOS due to including an incorrect PATH (for MacOS).

https://github.com/CircleCI-Public/node-orb/blob/master/src/commands/install-yarn.yml#L21

First reported here: https://discuss.circleci.com/t/having-fork-resource-temporarily-unavailable-when-running-commands-on-macos/30966/4?u=jcm

The incorrect path leads to slow processes on MacOS and errors similar to the following:
^D^D/tmp/.bash_env-5d10d6f32cffde0008c4dc34-0-build: fork: Resource temporarily unavailable

Expected behavior

Detect OS and change install path (@ganezasan has mentioned removing this line would work).

@KyleTryon
Copy link
Contributor Author

@ganezasan Created a proof - https://circleci.com/gh/ganezasan/circleci-sandbox/2627

@iynere Could we discuss how you would like this resolved in a "standardized" way?

@iynere
Copy link
Contributor

iynere commented Jun 27, 2019

@KyleTryon actually, this was already on my plate for today

@iynere
Copy link
Contributor

iynere commented Jun 27, 2019

@KyleTryon @ganezasan you can take a look at the (misleadingly named) test-against-oracle branch, where i'm refactoring for cross-platform compatibility across the orb commands

https://github.com/CircleCI-Public/node-orb/tree/test-against-oracle
https://circleci.com/gh/CircleCI-Public/node-orb/tree/test-against-oracle

@iynere iynere added the bug Something isn't working label Jun 27, 2019
@iynere
Copy link
Contributor

iynere commented Jun 27, 2019

#6 closes this

@iynere iynere closed this as completed Jun 27, 2019
@JCMais
Copy link

JCMais commented Jun 28, 2019

@iynere after updating the orb, I'm having the following error when running yarn config set cache-folder ~/.cache/yarn

#!/bin/bash --login -o pipefail
yarn config set cache-folder ~/.cache/yarn
^D��^D��yarn config v1.16.0
error An unexpected error occurred: "EACCES: permission denied, scandir '/Users/distiller/.config/yarn/link'".
info If you think this is a bug, please open a bug report with the information provided in "/Users/distiller/project/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/config for documentation about this command.
Exited with code 1

@iynere
Copy link
Contributor

iynere commented Jun 28, 2019

@JCMais did you try running it with sudo ?

@iynere
Copy link
Contributor

iynere commented Jun 28, 2019

@JCMais this is a separate issue so please open a new issue with further information, if you could

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants