Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflected-XSS/HTML Injection #248

Closed
satu0king opened this issue Mar 15, 2019 · 3 comments
Closed

Reflected-XSS/HTML Injection #248

satu0king opened this issue Mar 15, 2019 · 3 comments

Comments

@satu0king
Copy link
Member

Describe the bug
A user sent this mail

This is a seemingly minor bug, but it is identical to the self-retweeting tweet so it should probably be addressed immediately. If HTML is placed into the title of the project, it is interpreted as such by the editor. This only does anything in the editor, and all other situations are either protected or do not show the title. Script tags are the scary part.

I think everywhere, the text is escaped when rendered. However here, it is client-side rendering and is manually injected by javascript. It is not very critical as only the author can actually see the edit page but it will affect someone who forks the same circuit.

Are you working on this issue? (Yes/No)
No

@armudgal armudgal changed the title HTML Injection Reflected-XSS/HTML Injection Mar 16, 2019
@woswos
Copy link
Contributor

woswos commented Apr 5, 2019

I want to work on this, and I think this is a quite serious issue.

I have a way to fix it in my mind. I tried to find the exact code piece that dynamically changes the title based on the project properties entry. I might need some help to locate that code piece and apply the fix.

@SubhajitCode
Copy link
Contributor

#375 this is the critical varient as all the users will be affected by this vector

@github-actions
Copy link

github-actions bot commented Mar 5, 2020

No activity on this issue for a prolonged duration, will be closed in few days if no further activities in next 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants