Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubCircuit Surface LED's #36

Closed
soweli-Luna opened this issue Oct 30, 2018 · 7 comments
Closed

SubCircuit Surface LED's #36

soweli-Luna opened this issue Oct 30, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@soweli-Luna
Copy link

When customizing the layout of a SubCircuit, any LED's that have been placed should appear on the SubCircuit similar to inputs or outputs, but on the surface. A similar idea I just had is to do the same with buttons, allowing for a SubCircuit button panel.
Here's a graphical representation of what I mean about the surface LED's:
screenshot 2

@satu0king satu0king added the enhancement New feature or request label Oct 30, 2018
@satu0king
Copy link
Member

That is a great idea! The LEDs can be done right away, however, the buttons may be a tad bit trickier.

@soweli-Luna
Copy link
Author

Awesome! Also, the image is just a rough demonstration, I definitely would want it to look a little better than that.. particularly the non-lit LED's and the borders between them stick out way too much.

@satu0king
Copy link
Member

Should the LEDs be circular or square?, should there be a border around the LEDs?

@soweli-Luna
Copy link
Author

They should be square and "pixel-like." There should be a border, but a fainter one than in the image.

@SubhajitCode
Copy link
Contributor

hi I implemented this feature and creating a pull request to check them out .. please notify me if you find any bugs....
I really need some one who knows inside out of this project as mentor
ps.. those leds are circular now but will change them to rectangular later ...

@soweli-Luna
Copy link
Author

Hey @SubhajitCode, this issue is a bit outdated, it's reiterated in #48, go there instead. I'll close this issue, actually.

@SubhajitCode
Copy link
Contributor

here is the pull req
#210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants