Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Assignment Restricted Element Reporting #398

Closed
satu0king opened this issue Jul 2, 2019 · 4 comments · Fixed by #818
Closed

Improve Assignment Restricted Element Reporting #398

satu0king opened this issue Jul 2, 2019 · 4 comments · Fixed by #818

Comments

@satu0king
Copy link
Member

satu0king commented Jul 2, 2019

  1. Show restricted elements banner only if present
    image
  2. Show restricted elements across all scopes in assignment preview (when mentor sees)
  3. Improve restricted element detection
  4. Show warning message when circuit is saved
@ankitkataria
Copy link
Member

I'll start working into this. 😄

@satu0king
Copy link
Member Author

Oh, I was going to assign this to myself xD

@ankitkataria
Copy link
Member

We can divide work on this one too. Which ones would you want to pick?

@shubhankarsharma00
Copy link
Member

shubhankarsharma00 commented Nov 26, 2019

Leaving some added information:

  • To show Restricted Elements div only when applicable:
    Just add an if statement
    <%if @assignment.restricted_circuit_elements != "None"%>
    <p>
    <strong>Restricted Circuit Elements:</strong>
    <p> <%= @assignment.restricted_circuit_elements %> </p><br>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants