Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow freshclam downloadmanager to return FC_UPTODATE if no update was required #56

Closed
wants to merge 1 commit into from

Conversation

rkubik
Copy link
Contributor

@rkubik rkubik commented May 17, 2016

Useful for callers of this method to differentiate between a successful update or no update required.

vrtadmin pushed a commit that referenced this pull request Jun 13, 2016
vrtadmin pushed a commit that referenced this pull request Jun 13, 2016
@rkubik
Copy link
Contributor Author

rkubik commented Jul 28, 2016

I see that this has been added in 0.99.3, thanks.

@rkubik rkubik closed this Jul 28, 2016
@rma-x
Copy link

rma-x commented Aug 28, 2018

Russ, was it intentional that this does not only change the return code of downloadmanager(), but also the exit code of freshclam?

See also my comment on 5a0b539ca2 .

@rkubik
Copy link
Contributor Author

rkubik commented Sep 12, 2018

@rma-x Yes, changing freshclam's exit code was intentional however it was not captured in the release notes or man page - this was an oversight. Thank you for bringing this to our attention.

In version 0.101, the exit codes for freshclam will be reverted back to the original behaviour (prior to this patch - the libfreshclam downloadmanager changes will stay). The maintainers have expressed interest in reserving exit code 0 for success conditions and non-zero for errors. These changes will be documented in the release notes for visibility.

@micahsnyder
Copy link
Contributor

The change for 0.101 to report 0 for success, non-zero for failure was just sync'd to Github.
d0b738a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants