Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with entrypoing logging #18

Open
stavros-k opened this issue Apr 18, 2023 · 1 comment
Open

Issues with entrypoing logging #18

stavros-k opened this issue Apr 18, 2023 · 1 comment

Comments

@stavros-k
Copy link

stavros-k commented Apr 18, 2023

There is a log line in the entrypoint that it's supposed to overwrite the line with the new info. From my testing that's not happening.
I discovered it cause some CI runs testing a kubernetes deployment was never ending. Tried and reproduced it locally, and the only time this was happening was when the clamd socket was a bit late to startup.

Looking into the logs, looks like it was printing everything into a single line, causing logs exceed what a lot of kubernetes tools "accept" as a normal line size.

For example, native kubectl command to get logs, it was "replaying" the logs showing the overwrite happening in fast forward.
ct install (helm's testing tool) wasn't happy about this.
k9s also wasn't happy. When I tried to wrap the logs lines it was freezing up.

etcd on k8s have a limit of 1MiB for every object. which is most likely what's causing the problem here.
kubernetes/kubernetes#19781

Please consider instead of overwriting the line to just print it on a new line.

The line in question:

printf "\r%s" "Socket for clamd not found yet, retrying (${_timeout}/${CLAMD_STARTUP_TIMEOUT}) ..."

Thanks

@stavros-k
Copy link
Author

Just saw a PR addressing it #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant