Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ACI modules in community.network #36

Closed
gundalow opened this issue May 29, 2020 · 3 comments · Fixed by #39
Closed

Some ACI modules in community.network #36

gundalow opened this issue May 29, 2020 · 3 comments · Fixed by #39
Assignees

Comments

@gundalow
Copy link

gundalow commented May 29, 2020

Hi,

Should these modules be moved from community.network into this repo:
https://github.com/ansible-collections/community.network/tree/master/plugins/modules/network/aci

PR1: Add the files to this repo
PR2: Delete files from community.general
PR3 Update ansible/ansible's lib/ansible/config/ansible_builtin_runtime.yml to ensure that all ACI modules point to this collection.

@gundalow gundalow mentioned this issue May 29, 2020
@lhercot lhercot self-assigned this May 29, 2020
@lhercot
Copy link
Member

lhercot commented May 29, 2020

Hi Gundalow,

I am working on PR1.
Will follow once we are ready with it.

@gundalow
Copy link
Author

Excellent, thank you for the quick response. Please do feel free to shout out if you hit any issues.

@lhercot
Copy link
Member

lhercot commented Jun 18, 2020

Modules were already in the repo. Just updated the name of some of the test to match the ones in community.network.
So PR1 is complete.
To the best of my knowledge PR2 and PR3 are also completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants