Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add cpp coverage #705

Merged
6 commits merged into from Mar 8, 2018
Merged

Re-add cpp coverage #705

6 commits merged into from Mar 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 8, 2018

  • Add -DCOVERAGE=True option to cpp CMakeLists.txt
  • Also re-add macOS test with allowing for failure

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #705 into master will increase coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #705      +/-   ##
=========================================
+ Coverage    73.9%   74.6%   +0.69%     
=========================================
  Files         104     162      +58     
  Lines       10446   14804    +4358     
  Branches     1431    1431              
=========================================
+ Hits         7720   11044    +3324     
- Misses       2421    3455    +1034     
  Partials      305     305
Impacted Files Coverage Δ
sdk/cpp/core/src/entity_util.cpp 75% <0%> (ø)
sdk/cpp/core/src/ydk.cpp 25.52% <0%> (ø)
sdk/cpp/core/src/executor_service.cpp 90.38% <0%> (ø)
sdk/cpp/core/src/restconf_provider.cpp 100% <0%> (ø)
sdk/cpp/core/src/codec_service.cpp 73.43% <0%> (ø)
sdk/cpp/core/src/logging_callback.hpp 0% <0%> (ø)
sdk/cpp/core/tests/core_test.cpp 100% <0%> (ø)
sdk/cpp/core/src/path/restconf_session.cpp 89.58% <0%> (ø)
sdk/cpp/core/src/opendaylight_parser.cpp 95.38% <0%> (ø)
sdk/cpp/core/src/bits.cpp 100% <0%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82206af...9ff41ba. Read the comment docs.

@ghost ghost merged commit 0e92490 into CiscoDevNet:master Mar 8, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants