Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated docker build #724

Merged
2 commits merged into from Mar 26, 2018
Merged

Add automated docker build #724

2 commits merged into from Mar 26, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2018

  • Automatically build docker images for ydk-gen, ydk-py and ydk-go

Copy link
Contributor

@ylil93 ylil93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change

@ghost ghost merged commit 0396018 into CiscoDevNet:master Mar 26, 2018
@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #724 into master will decrease coverage by 2.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   80.46%   77.67%    -2.8%     
==========================================
  Files         170       68     -102     
  Lines       16268     5661   -10607     
  Branches     1470        0    -1470     
==========================================
- Hits        13090     4397    -8693     
+ Misses       2820     1221    -1599     
+ Partials      358       43     -315
Impacted Files Coverage Δ
sdk/go/core/ydk/types/types.go 57.14% <0%> (-11.51%) ⬇️
sdk/cpp/core/src/path/repository.cpp 87.3% <0%> (-0.4%) ⬇️
ydkgen/builder/_api_model_builder.py
sdk/python/core/ydk/errors/__init__.py
ydkgen/printer/printer_context.py
ydkgen/printer/python/class_inits_printer.py
ydkgen/printer/python/import_test_printer.py
sdk/python/core/tests/test_sanity_types.py
sdk/python/core/ydk/services/executor_service.py
sdk/python/core/tests/test_sanity_path.py
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b8708...0791157. Read the comment docs.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant