#675 cascading typedefs patch #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ylil93
commented
Apr 5, 2018
ylil93
commented
- update generator to differentiate typedefs with the same base type
- added sanity test case
- generated documentation is wrong (api model/builder issue)
- update generator to differentiate typedefs with the same base type - added sanity test case - generated documentation is wrong (api model/builder issue)
ghost
approved these changes
Apr 5, 2018
ghost
merged commit 
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
+ Coverage 80.52% 80.53% +0.01%
==========================================
Files 171 171
Lines 16457 16458 +1
Branches 1495 1495
==========================================
+ Hits 13252 13255 +3
+ Misses 2836 2835 -1
+ Partials 369 368 -1
Continue to review full report at Codecov.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.